Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: perf improvements #1139

Merged
merged 3 commits into from
Jan 15, 2025
Merged

chore: perf improvements #1139

merged 3 commits into from
Jan 15, 2025

Conversation

JimFuller-RedHat
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat commented Jan 14, 2025

Most visibly (and easy to adhoc test) this resolves list of vulns faster on http://localhost:8080/sboms listing and http://localhost:8080/vulnerabilities.

Also various speed improvements in various places.

Addresses both #1018 and #1140.

@JimFuller-RedHat JimFuller-RedHat self-assigned this Jan 14, 2025
@JimFuller-RedHat JimFuller-RedHat marked this pull request as draft January 14, 2025 14:11
@JimFuller-RedHat JimFuller-RedHat force-pushed the perf-sbom-detail branch 3 times, most recently from 36023ed to 8e34db1 Compare January 14, 2025 14:42
@JimFuller-RedHat JimFuller-RedHat marked this pull request as ready for review January 14, 2025 14:45
@JimFuller-RedHat
Copy link
Collaborator Author

JimFuller-RedHat commented Jan 14, 2025

@dejanb there is one failing test - because we need to make a decision if we parameterise this for status (currently baked in as 'affected' ) ... the current test needs to change but want to discuss with you first (resolved and added #1145).

@dejanb
Copy link
Contributor

dejanb commented Jan 15, 2025

@JimFuller-RedHat I think we should propagate the filter all the way to the API, so that we can fetch only certain status like we need for this use case but allow folks to fetch all statuses if they need to.

@JimFuller-RedHat JimFuller-RedHat changed the title perf improvements chore: perf improvements Jan 15, 2025
@JimFuller-RedHat JimFuller-RedHat added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 3499a7c Jan 15, 2025
1 check passed
@JimFuller-RedHat JimFuller-RedHat deleted the perf-sbom-detail branch January 15, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants